[Refactor] no-*-set-state: improve performance

jsx-eslint · Apr 16, 2022 · 3bc35b3 · 3bc35b3
1 parent 96b3b06
commit 3bc35b3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/util/makeNoMethodSetStateRule.js b/lib/util/makeNoMethodSetStateRule.js
@@ -73,16 +73,16 @@ module.exports = function makeNoMethodSetStateRule(methodName, shouldCheckUnsafe
         return false;
       }
 
+      if (shouldBeNoop(context, methodName)) {
+        return {};
+      }
+
       // --------------------------------------------------------------------------
       // Public
       // --------------------------------------------------------------------------
 
       return {
         CallExpression(node) {
-          if (shouldBeNoop(context, methodName)) {
-            return;
-          }
-
           const callee = node.callee;
           if (
             callee.type !== 'MemberExpression'