Merge pull request #1077 from iancmyers/fix-jsx-indent-template-condi…

…tional Fix error caused by templates in ConditionalExpressions (jsx-indent)
jsx-eslint · Feb 17, 2017 · 22f3638 · 22f3638
2 parents a4b6a85 + c6f4a5e
commit 22f3638
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 1 deletion.
diff --git a/lib/rules/jsx-indent.js b/lib/rules/jsx-indent.js
@@ -275,7 +275,8 @@ module.exports = {
         do {
           prevToken = sourceCode.getTokenBefore(prevToken);
         } while (prevToken.type === 'Punctuator');
-        prevToken = sourceCode.getNodeByRangeIndex(prevToken.start);
+        prevToken = sourceCode.getNodeByRangeIndex(prevToken.range[0]);
+
         while (prevToken.parent && prevToken.parent.type !== 'ConditionalExpression') {
           prevToken = prevToken.parent;
         }

diff --git a/tests/lib/rules/jsx-indent.js b/tests/lib/rules/jsx-indent.js
@@ -410,6 +410,47 @@ ruleTester.run('jsx-indent', rule, {
     ].join('\n'),
     options: [4, {indentLogicalExpressions: true}],
     parserOptions: parserOptions
+  }, {
+    code: [
+      '<span>',
+      '  {condition ?',
+      '    <Thing',
+      '      foo={`bar`}',
+      '    /> :',
+      '    <Thing/>',
+      '  }',
+      '</span>'
+    ].join('\n'),
+    options: [2],
+    parserOptions: parserOptions
+  }, {
+    code: [
+      '<span>',
+      '  {condition ?',
+      '    <Thing',
+      '      foo={"bar"}',
+      '    /> :',
+      '    <Thing/>',
+      '  }',
+      '</span>'
+    ].join('\n'),
+    options: [2],
+    parserOptions: parserOptions
+  }, {
+    code: [
+      'function foo() {',
+      '  <span>',
+      '    {condition ?',
+      '      <Thing',
+      '        foo={super}',
+      '      /> :',
+      '      <Thing/>',
+      '    }',
+      '  </span>',
+      '}'
+    ].join('\n'),
+    options: [2],
+    parserOptions: parserOptions
   }],
 
   invalid: [{