Addressed change requests.

jsx-eslint · Sep 15, 2020 · 1929be2 · 1929be2
1 parent 69671b3
commit 1929be2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/docs/rules/jsx-no-literals.md b/docs/rules/jsx-no-literals.md
@@ -26,7 +26,7 @@ var Hello = <div>
 
 ## Rule Options
 
-There are three options:
+The supported options are:
 
 * `noStrings` (default: `false`) - Enforces no string literals used as children, wrapped or unwrapped.
 * `allowedStrings` - An array of unique string values that would otherwise warn, but will be ignored.

diff --git a/lib/rules/jsx-no-literals.js b/lib/rules/jsx-no-literals.js
@@ -45,7 +45,6 @@ module.exports = {
           type: 'boolean'
         }
       },
-
       additionalProperties: false
     }]
   },
@@ -94,7 +93,7 @@ module.exports = {
       const parent = getParentIgnoringBinaryExpressions(node);
 
       function isParentNodeStandard() {
-        if (!/^[\s]+$/.test(node.value) && typeof node.value === 'string' && parent.type.indexOf('JSX') !== -1) {
+        if (!/^[\s]+$/.test(node.value) && typeof node.value === 'string' && parent.type.includes('JSX')) {
           if (config.noAttributeStrings) {
             return parent.type === 'JSXAttribute';
           }