Merge pull request #1218 from jseminck/no-unused-prop-types-bug

Fix false positive in no-unused-proptype
jsx-eslint · May 24, 2017 · 089beec · 089beec
2 parents b74a693 + bf69820
commit 089beec
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 1 deletion.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -99,9 +99,12 @@ Components.prototype.list = function() {
       component = this.get(node);
     }
     if (component) {
-      usedPropTypes[this._getId(component.node)] = (this._list[i].usedPropTypes || []).filter(function(propType) {
+      const newUsedProps = (this._list[i].usedPropTypes || []).filter(function(propType) {
         return !propType.node || propType.node.kind !== 'init';
       });
+
+      const componentId = this._getId(component.node);
+      usedPropTypes[componentId] = (usedPropTypes[componentId] || []).concat(newUsedProps);
     }
   }
   // Assign used props in not confident components to the parent component

diff --git a/tests/lib/rules/no-unused-prop-types.js b/tests/lib/rules/no-unused-prop-types.js
@@ -1439,6 +1439,51 @@ ruleTester.run('no-unused-prop-types', rule, {
         '}'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      // The next two test cases are related to: https://github.com/yannickcr/eslint-plugin-react/issues/1183
+      code: [
+        'export default function SomeComponent(props) {',
+        '    const callback = () => {',
+        '        props.a(props.b);',
+        '    };',
+        '',
+        '    const anotherCallback = () => {};',
+        '',
+        '    return (',
+        '        <SomeOtherComponent',
+        '            name={props.c}',
+        '            callback={callback}',
+        '        />',
+        '    );',
+        '}',
+        '',
+        'SomeComponent.propTypes = {',
+        '    a: React.PropTypes.func.isRequired,',
+        '    b: React.PropTypes.string.isRequired,',
+        '    c: React.PropTypes.string.isRequired,',
+        '};'
+      ].join('\n')
+    }, {
+      code: [
+        'export default function SomeComponent(props) {',
+        '    const callback = () => {',
+        '        props.a(props.b);',
+        '    };',
+        '',
+        '    return (',
+        '        <SomeOtherComponent',
+        '            name={props.c}',
+        '            callback={callback}',
+        '        />',
+        '    );',
+        '}',
+        '',
+        'SomeComponent.propTypes = {',
+        '    a: React.PropTypes.func.isRequired,',
+        '    b: React.PropTypes.string.isRequired,',
+        '    c: React.PropTypes.string.isRequired,',
+        '};'
+      ].join('\n')
     }
   ],