New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow menuitemradio
and menuitemcheckbox
on <li>
#950
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 105 105
Lines 1636 1642 +6
Branches 579 578 -1
=======================================
+ Hits 1620 1626 +6
Misses 16 16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @khiga8 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs some tests.
{ code: '<li role="menuitemcheckbox" />;' }, | ||
{ code: '<li role="menuitemradio" />;' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the requested test!
Fixes: #896
Currently, the
jsx-a11y/no-noninteractive-element-to-interactive-role
rule flags<li role="menuitemradio">
and<li role="menuitemcheckbox">
. I don't think these should be flagged, especially given we allow<li role="menuitem">
.Conflicting recommendations:
<li role="menuitemradio">
.