Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] no-redundant-roles, role-supports-aria-props: Remove implicit role from dl element #848

Merged
merged 1 commit into from Apr 15, 2022
+1 −12
Merged

[Fix] no-redundant-roles, role-supports-aria-props: Remove implicit role from dl element #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions __tests__/src/rules/no-redundant-roles-test.js
View file
Open in desktop
Expand Up @@ -77,6 +77,7 @@ ruleTester.run(`${ruleName}:recommended (valid list role override)`, rule, {
valid: [
{ code: '<ul role="list" />' },
{ code: '<ol role="list" />' },
{ code: '<dl role="list" />' },
]
.map(ruleOptionsMapperFactory(listException))
.map(parserOptionsMapper),
Expand Down
4 changes: 0 additions & 4 deletions __tests__/src/rules/role-supports-aria-props-test.js
View file
Open in desktop
Expand Up @@ -432,10 +432,6 @@ ruleTester.run('role-supports-aria-props', rule, {
code: '<dialog aria-expanded />',
errors: [errorMessage('aria-expanded', 'dialog', 'dialog', true)],
},
{
code: '<dl aria-expanded />',
errors: [errorMessage('aria-expanded', 'list', 'dl', true)],
},
{
code: '<aside aria-expanded />',
errors: [errorMessage('aria-expanded', 'complementary', 'aside', true)],
Expand Down
6 changes: 0 additions & 6 deletions src/util/implicitRoles/dl.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/util/implicitRoles/index.js
View file
Open in desktop
Expand Up @@ -7,7 +7,6 @@ import button from './button';
import datalist from './datalist';
import details from './details';
import dialog from './dialog';
import dl from './dl';
import form from './form';
import h1 from './h1';
import h2 from './h2';
Expand Down Expand Up @@ -46,7 +45,6 @@ export default {
datalist,
details,
dialog,
dl,
form,
h1,
h2,
Expand Down