New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Introduce a plugin-wide setting for custom components. #844
Conversation
Codecov Report
@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 99.22% 99.25% +0.03%
==========================================
Files 98 99 +1
Lines 1417 1476 +59
Branches 479 482 +3
==========================================
+ Hits 1406 1465 +59
Misses 11 11
Continue to review full report at Codecov.
|
Love it, thank you for starting this. I have a 10 week old at home and he's been a bit of a drag on time and energy for Open Source :) I'll try to find time to review, but if I'm a little slow, it's cause I'm changing diapers ;p |
ef9f86b
to
5bb6018
Compare
d46912e
to
936e871
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I'm done updating every existing rule and helper function that was using the raw |
We also need something like this, because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
For #174
This is an early version of the change I want to introduce: there are still some rules that I haven't updated.
Can you start a review on the API and the implementation to see if I should finish it please?