Use the recommended gradle/actions/setup-gradle@v3 #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netdpb
reviewed
Feb 7, 2024
| @@ -76,15 +76,15 @@ jobs: | |||
| - name: Run Conformance Tests | |||
| if: github.base_ref == 'main' # only PRs onto main | |||
| continue-on-error: true | |||
| uses: gradle/gradle-build-action@v2 | |||
| uses: gradle/actions/setup-gradle@v3 | |||
There was a problem hiding this comment.
I think the recommended pattern is to have a single, separate step to set up Gradle, and then to just run Gradle as a normal shell invocation.
See the publish-snapshot job above.
|
Oops, sorry: I was merging old PRs (since those contain versions of files without licenses, which upsets our licensing tooling), and I merged that one before noticing this. Obviously we could still do this, but you'll now have a merge conflict :\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#476 suggests doing this update instead of merging #476.