-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to clarify AugmentedInferenceAgreesWithBaseInference. #287
base: main
Are you sure you want to change the base?
Conversation
This is still far from a full explanation, but it's less incorrect and slightly more informative. I hope.
* | ||
* Notice that `makeList(a, b)` is fine "in a vacuum" even under JSpecify (as shown above). Only | ||
* here, where the type of the expression is forced to conform to the target type, is there a | ||
* problem. | ||
* here, where the type of the expression is forced to conform to the javac's type for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the expression type is being forced to conform to JSpecify's preferred type. No?
* | ||
* Notice that `makeList(a, b)` is fine "in a vacuum" even under JSpecify (as shown above). Only | ||
* here, where the type of the expression is forced to conform to the target type, is there a | ||
* problem. | ||
* here, where the type of the expression is forced to conform to the javac's type for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* here, where the type of the expression is forced to conform to the javac's type for the | |
* here, where the type of the expression is forced to conform to javac's type for the |
Just keep noticing this hanging around in our PRs tab. No biggie but here's a bump if you wanted one. |
This is still far from a full explanation, but it's less incorrect and
slightly more informative. I hope.