Make mypy_plugin compatible with mypy>=0.730 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed SimpleBuffer since it seems unnecessary atm * This avoids type errors down the line
wchresta
force-pushed
the
fix_issue_21
branch
from
22e523c
to
a52fede
Compare
Merged
jspahrsummers
approved these changes
Dec 30, 2019
requirements.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| yapf==0.27.0 | |||
| mypy==0.711 | |||
| mypy>=0.711 | |||
There was a problem hiding this comment.
I'd prefer for requirements.txt to actually be a snapshot of known-working dependencies, so anyone can pip install -r requirements.txt and know that their setup should work. This range leaves open the possibility that it may break again the future.
How about something like, e.g.:
Suggested change
| mypy>=0.711 | |
| mypy>=0.711, <=0.761 |
* This fixes issue 21 * New type_analyze_hook to fix types before mypy's semantic analyzer runs * _get_and_delete_cases defers if it encounters PlaceholderNodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new hook to change the type
mypysees before the semantic analyzer runs. This is briefly discussed in #21The other issues raised in my comment turned out to be bugs that already existed for the old mypy version, too. These are not addressed with this fix.
This has been tested with
mypy==0.711andmypy=0.761