Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Whitelist str for skipping read-only attributes
* Fix #478 by whitelisting str for skipping read-only attrs * Add changelog entry for str errors * Move new fix from 3.0.3 to 3.0.4
- Loading branch information
Showing
2 changed files
with
9 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
423faa8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davvid Do you by any chance know what's causing the ruff tests to fail for this?
423faa8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll prep an MR shortly. There's a breaking change in pytest-ruff with newer versions of pytest.
businho/pytest-ruff#15
pytest-dev/pytest#12069
I originally worked around it by excluding specifically pytest-ruff 0.3.1 but it looks like they just released 0.3.2 and the issue remains.
I'll pin it down to
pytest-ruff < 0.3
shortly. That gets it to passmake tox
locally here.423faa8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should also be noted that as soon as we upgrade to ruff 0.3 the format does change (
make format
results in edits).We can defer that until later when we know that pluggy + pytest + ruff are all in good shape.