Fix the issue 629 and add two testcases #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kallestenflo I noticed merging this broke master. I rebased this branch against ca04684 and found that the tests fail the same way, though this PR was good back in April based on f3c8fd7. Could it be rolled back so it can be amended please? |
|
PS do you need some help setting up CI to catch things like this and make it less of a burden? |
|
there is no need to roll this back, it does the right thing. A regression was introduced between its implementation and merging it, I fixed that here: #763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have fix the issue #629 and add two testcases for it. I add some code to check the match os parenthesis when compiling the path to throw an exception when a CLOSE_PARENTHESIS loss.