Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic support of Java 16 records #312

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Basic support of Java 16 records #312

wants to merge 16 commits into from

Conversation

mxyns
Copy link

@mxyns mxyns commented Mar 6, 2022

This pull request tries to address the issue #302

This solution uses the Record's canonical constructor by default to create instances of the Records. Other constructors can be used
with @JsonCreator and @JsonProperty (see added tests in src/test/java/com/jsoniter/TestRecord.java).

mxyns and others added 16 commits March 2, 2022 09:54
@mxyns
feat - migrated maven project to java 16 (#1)
e598ce7
@mxyns
Merge pull request #2 from noahra/issue/#1
fc8c4d8 
feat - migrated maven project to java 16 (#1)
@mxyns
test - failing test for unsupported Record (#3)
fff39bd
@mxyns
Merge pull request #4 from noahra/issue/#3
7fc8851 
test - failing test for unsupported Record (#3)
@lnsandnkth
test - add serialization test (#7)
4766703 
test - add serialization test (#7)
actually already works
@lnsandnkth
Merge pull request #8 from noahra/issue/#7
0d893a4 
test - add serialization test (#7)
@lnsandnkth
test - fix added assertion (#3)
da40903 
test - fix added assertion (#3)
@lnsandnkth
Merge pull request #10 from noahra/issue/#3
6927007 
test - fix added assertion (#3)
closes #3
@yuxin-miao @mxyns
feat - record support with canonical constructor (#5) (PR #13)
077c4d5 
* tmp - record investigation / debugging

* test - empty record read

* test - tests showing different object decoder implementation use

Co-authored-by: Maxou <5208681+mxyns@users.noreply.github.com>
Co-authored-by: xinmiao <>
@mxyns
feat - handle multiple record constructors by using canonical constru…
149b796 
…ctor by default (#12)
@lnsandnkth
test - add tests for any wrap and stream (#15)
4b7c1f0 
test - add tests for any wrap and stream (#15)
@lnsandnkth
Merge pull request #17 from noahra/issue/#15
ac59b48 
test - add tests for any wrap and stream (#15)
closes #15
@mxyns
test - example of use of another constructor for record decoding (#16)
8dc32ff
@mxyns
clean - reemoved syso/sout (#19)
f921396
@mxyns
clean - removed unsused imports (#19)
2d2ff04
@yuxin-miao
test - add tests for getRecordCtor (#21)
37a6755
@Brixomatic
Copy link

I've included this in my pull request #325 thanks a lot!

@schrepfler
Copy link

Any chance this can be accepted @svobol13 and released? I've noticed the fempoframework is maintaining a fork with a bit of additional work, perhaps @shaoxt can pick up some maintainer responsibilities?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mxyns @Brixomatic @schrepfler @lnsandnkth @yuxin-miao