Add #[builder(crate = "parol_runtime::derive_builder")] #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryo33 Very good. |
ryo33
force-pushed
the
derive-builder-export
branch
from
c6f1ee2
to
84f4422
Compare
|
@jsinger67 Now I think it's ready to merge. |
|
Works perfectly 💯 |
|
I released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #23.
I've tried to extract boilerplates into
parol_runtime, but we still needpub use parol_runtime::derive_builderinlib.rsormain.rsbecausederive_builderdoes not support re-exporting.Now we can remove it, thanks to colin-kiegel/rust-derive-builder#275.
This is a draft because it uses not released version of
derive_builder.