Improve handling of exported bindings #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend consideration to include bindings created using DestructuringBindingPattern.
Currently, the `setExported` method only makes the specified binding as "used." This is unnecessary in this context because when `expression` processes an IdentifierReference, it does the same. Remove the branch.
jugglinmike
force-pushed
the
duplicate-exports
branch
from
6fa4464
to
62f448f
Compare
rwaldron
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might not look like it, but this is in support of ES2020's new production,
export default as ns from '';(tracking via gh-3486).