Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[FEAT]] Add support for import.meta #3490

Closed
wants to merge 1 commit into from

Conversation

jugglinmike
Copy link
Member

Tolerate parsing errors regarding escape sequences in IdentifierNames as
these reflect a pre-existing deficiency which will require a dedicated
patch to correct.

Tolerate parsing errors regarding escape sequences in IdentifierNames as
these reflect a pre-existing deficiency which will require a dedicated
patch to correct.
@coveralls
Copy link

Coverage Status

Coverage increased (+6.0e-05%) to 99.978% when pulling e25c832 on jugglinmike:import-meta into 067aad1 on jshint:v2.12.0.

Copy link
Member

@rwaldron rwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rwaldron
Copy link
Member

@jugglinmike I've rebased this for you and merged it into v2.12.0

@rwaldron rwaldron closed this Jul 29, 2020
@akvadrako
Copy link

It looks like this was never merged.

@jugglinmike
Copy link
Member Author

You're right, @akvadrako! I've cherry-picked it back into the feature branch for version 2.13; that's not apparent on this page because GitHub isn't aware of the change, but you can verify by checking the commit history on that branch.

Thanks for keeping an eye out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants