[[FIX]] Correct parsing of class method names #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#3379 has landed |
jugglinmike
force-pushed
the
class-method-names
branch
from
b619b1c
to
a998b6a
Compare
|
Rebased and passing as expected, @rwaldron |
rwaldron
reviewed
Apr 9, 2019
| @@ -10842,8 +10840,6 @@ test/language/statements/class/elements/syntax/valid/grammar-privatename-no-init | |||
| test/language/statements/class/elements/syntax/valid/grammar-privatename-no-initializer-with-method.js(strict mode) | |||
| test/language/statements/class/elements/syntax/valid/grammar-privatenames-multi-line.js(default) | |||
| test/language/statements/class/elements/syntax/valid/grammar-privatenames-multi-line.js(strict mode) | |||
| test/language/statements/class/elements/syntax/valid/grammar-static-ctor-accessor-meth-valid.js(default) | |||
| test/language/statements/class/elements/syntax/valid/grammar-static-ctor-accessor-meth-valid.js(strict mode) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rwaldron I found an unrelated bug while fixing gh-3381, and I've included a
patch for that here, too. gh-3381 only effected class methods, but I added a
regression tests for method defined in object initializers for good measure.