Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon #48

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Favicon #48

wants to merge 1 commit into from

Conversation

pmaxhogan
Copy link

This is a patch for a favicon.

@pmaxhogan pmaxhogan mentioned this pull request Jan 29, 2017
@jugglinmike
Copy link
Member

Thanks for the patch! Unfortunately, it's formatted incorrectly, so we can't
accept it as-is. I can offer you some help to fix it, though.

You'll want to start by making sure you have checked out the latest version of
the dev branch. Be sure that there are no additional commits "on top" of that
(use git log to check) and that there are no new "unstaged" local changes
(use git status to check).

The tricky part here is that we need to deploy this file to the root of the
site's public file hierarchy, but the current build system isn't really set up
for such an operation. If you place the file in the res/ directory, I would
accept a quick-and-dirty alteration to the project Makefile that copied it
into place at deploy time.

Finally, your pull request should target the dev branch. We'll take care of
updating the master branch the next time we deploy the site.

It's a bit convoluted, to be sure. Does my explanation make sense to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants