Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the RegExp flag used for input pattern validation #3681

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix the RegExp flag used for input pattern validation #3681

wants to merge 2 commits into from
+12 −6

Commits on May 26, 2024

  1. Fix the RegExp flag used for input pattern validation 

    According to MDN (https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/pattern#overview),
the RegExp flag was changed from 'u' to 'v' around mid-2023, so jsdom
should update to match that.
    @stnguyen90 @domenic
    stnguyen90 authored and domenic committed May 26, 2024
    Configuration menu
    Copy the full SHA
    7ad2c6e View commit details
    Browse the repository at this point in the history

  2. Expect fail in node 18 due to invalid flag

    @stnguyen90 @domenic
    stnguyen90 authored and domenic committed May 26, 2024
    Configuration menu
    Copy the full SHA
    3a6f5de View commit details
    Browse the repository at this point in the history