Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs that have been moved #3651

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DanKaplanSES
Copy link
Contributor

  • These URLs now link directly to the moved location

@domenic
Copy link
Member

domenic commented Jan 5, 2024

I appreciate the URL changes, but I don't think it's good that you've changed the grammar and style to suit your voice instead of mine. (The extra "that" in "To write such a test that, simply" is indeed an error, though.)

If you could revert such changes I'd accept this PR. Also, the package-lock.json change is not helpful. (Presumably you are using a different npm version than I.)

Contributing.md Outdated Show resolved Hide resolved
Contributing.md Outdated Show resolved Hide resolved
Contributing.md Outdated Show resolved Hide resolved
@DanKaplanSES
Copy link
Contributor Author

@domenic Done. LMK if I missed anything. Thanks.

@domenic
Copy link
Member

domenic commented Jan 21, 2024

Please also remove the package-lock.json change.

@DanKaplanSES
Copy link
Contributor Author

@domenic

Please also remove the package-lock.json change.

🤦‍♂️I'm so sorry for forgetting that a second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants