-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wpt #3633
Merged
Merged
Update wpt #3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 24455eb.
Fix test failure. It seems that setTimeout / setInterval is called outside the test.
Add a function to avoid infinite server startup attempts.
PR ready. Logs in case of server errors: |
asamuzaK
commented
Dec 8, 2023
domenic
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Truly amazing work; thank you so much! I pushed an extra commit with some more runner improvements; after CI completes on that I'll merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated wpt tests and related files.
Some notes:
package.json
update-wpt
script.--init
cmd arg.python3
topython
.wpt-config.json
andtuwpt-config.json
"log_level": "info",
toto-upstream/html/webappapis/timers/settimeout-setinterval-handles.html
It seems that setTimeout / setInterval is called somewhere outside the test, maybe in
testharness.js
.wpt-server.js