Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wpt #3633

Merged
merged 28 commits into from
Dec 23, 2023
Merged

Update wpt #3633

merged 28 commits into from
Dec 23, 2023

Conversation

asamuzaK
Copy link
Contributor

@asamuzaK asamuzaK commented Dec 4, 2023

Updated wpt tests and related files.

Some notes:

  • package.json
    • Updated update-wpt script.
      • Added --init cmd arg.
      • Changed python3 to python.
  • wpt-config.json and tuwpt-config.json
    • Changed "log_level": "info", to
      "logging": {
        "level": "info"
      },
      
  • to-upstream/html/webappapis/timers/settimeout-setinterval-handles.html
    • Fixed test failure.
      It seems that setTimeout / setInterval is called somewhere outside the test, maybe in testharness.js.
  • wpt-server.js
    • Added new function to avoid infinite server startup attempts.

@asamuzaK asamuzaK marked this pull request as draft December 4, 2023 13:21
@asamuzaK asamuzaK marked this pull request as ready for review December 5, 2023 15:30
@asamuzaK
Copy link
Contributor Author

asamuzaK commented Dec 6, 2023

PR ready.

Logs in case of server errors:

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly amazing work; thank you so much! I pushed an extra commit with some more runner improvements; after CI completes on that I'll merge.

@domenic domenic merged commit 63265a9 into jsdom:main Dec 23, 2023
5 checks passed
@asamuzaK asamuzaK deleted the wpt branch December 23, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants