downstream dependency change breaks backwards compatibility #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a result jsdom will no longer work with pre v4
|
That's very unfortunate :/ But this PR LGTM. Also see request/request#2772 and request/request#2774. |
|
But that note is still correct... It says "work with Node.js v4" rather than pre-v4, which are the versions affected by this. |
|
Yeah this doesn't seem accurate. Let me close this, per @Zirro's comment. If we've misunderstood, happy to reopen. |
|
my mistake - I slightly misread that line while trying to track down the problems yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request 2.82.0 to 2.82.1 made a breaking change in dependencies and as a result jsdom will no longer work with pre v4