Fix GCS signed urls when using custom endpoint. #837
Conversation
Fix the generation of signed URLs in Google Cloud Storage when using a custom endpoint. The previous behavior generates an invalid URL due to the inclusion of the GCS bucket name (e.g. "https://custom_endpoint/bucket_name/filename?signed" instead of "https://custom_endpoint/filename?signed"). Since the "generate_signed_url" method does not natively support custom endpoints, create a signed URL with the standard endpoint and manually replace it (and the bucket name) with the custom endpoint.
|
Is there a bug on the library about this? |
googleapis/python-storage#11. That issue doesn't have much information, but the same issue on the C++ version of the library (googleapis/google-cloud-cpp#3328) makes it clear that "bucket-bound hostnames" are custom endpoints. |
|
Looks like this was fixed in the underlying Python library (although with kind of bizarre param names). Unless I'm misunderstanding the fix. |
|
Sorry for the delay on responding to this. The change in google-cloud-storage doesn't affect this PR because it is only for v4 signed URLs and custom endpoints currently use v2 signed URLs (see #648 (comment) for more information on why this is). In addition, it only exists in google-cloud-storage >= 1.27.0. |
|
Closing this because I believe my other pull request (see above) is a more elegant solution. |
Fix the generation of signed URLs in Google Cloud Storage when using a custom endpoint (see #648). The previous behavior generates an invalid URL due to the inclusion of the GCS bucket name (e.g. "https://custom_endpoint/bucket_name/filename?signed" instead of "https://custom_endpoint/filename?signed").
Since the "generate_signed_url" method does not natively support custom endpoints, create a signed URL with the standard endpoint and manually replace it (and the bucket name) with the custom endpoint.