Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file seek error in boto3 - closes #382 #717

Closed
wants to merge 1 commit into from

Conversation

nikolas
Copy link
Contributor

@nikolas nikolas commented Jun 20, 2019

This is the solution from @charlesthk here:
#382 (comment)

@0011001011
Copy link

Any plan on making it pass test then merge ? I happened to have this problem and it is becoming more and more common.

I got the reference from this thread :
https://www.bountysource.com/issues/48279727-s3boto3storage-raises-valueerror-i-o-operation-on-closed-file

@nikolas
Copy link
Contributor Author

nikolas commented Aug 27, 2019

@0011001011 it looks like it's failing on some encoding errors, like this:

    def write(self, s):
        file = self._file
>       rv = file.write(s)
E       TypeError: a bytes-like object is required, not 'str'

I will address this unless someone else gets to it first.

@jschneier
Copy link
Owner

Merged #754 to fix this instead, thanks for your contribution.

@jschneier jschneier closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants