Limit and update required Azure packages #681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit and update required Azure packages
|
+1 for this. Requiring the base azure package pulls in far too many azure sub modules that are not needed. This is making our CI tests slower than they need to be. |
nitely
reviewed
Mar 15, 2019
| @@ -15,7 +15,7 @@ def read(filename): | |||
| python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*", | |||
| install_requires=['Django>=1.11'], | |||
| extras_require={ | |||
| 'azure': ['azure>=3.0.0', 'azure-storage-blob>=1.3.1'], | |||
| 'azure': ['azure-common', 'azure-storage-blob>=1.3.1'], | |||
There was a problem hiding this comment.
azure-common should be removed. azure-storage-blob already depends on it (so it will install it)
There was a problem hiding this comment.
I took this into consideration in #684
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit and update required Azure packages. See issue #680