Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azure name cleanup #671

Closed

Conversation

nitely
Copy link
Contributor

@nitely nitely commented Feb 20, 2019

fixes #609

Changes:

  • remove stripping special characters from file name
  • escape URL reserved and unsafe characters on url method

Notes:

  • This is consistent with the other storages
  • Django does the same name cleaning as the previous code, anyway
  • Django name cleaning can be bypassed by overriding get_valid_name or calling default_storage.save directly. This was not possible with the old code
  • Since this is a superset of what was previously allowed, it's a minor breaking change
  • Files uploaded with the previous code will still work

@nitely nitely changed the title Fix Azure remove name cleanup Fix Azure name cleanup Feb 23, 2019
@sww314 sww314 added the azure label May 10, 2019
@jschneier
Copy link
Owner

@nitely is this still necessary with your other branch now merged?

@nitely
Copy link
Contributor Author

nitely commented Sep 9, 2019

Yes, this removes some silly restrictions in file names. I made anew PR with all conflicts resolved #752

@nitely nitely closed this Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure backend strips some non-alphabetic characters from the file name
3 participants