Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publicRead ACL #641

Closed
wants to merge 3 commits into from
Closed

publicRead ACL #641

wants to merge 3 commits into from

Conversation

mj8894
Copy link

@mj8894 mj8894 commented Dec 20, 2018

  • handling defaultACL when creating a bucket file using write operation.

@sww314
Copy link
Contributor

sww314 commented Dec 20, 2018

Storages should not do this. It will mangle any custom ACLs users put on their files outside of the django-storages.
The ACL is set only on create on purpose - it is a default.
Consider, this example:

  1. Set default acl to projectPrivate.
  2. Share with userA + userB outside of storages.
  3. Save file with minor update.
  4. userA + userB would not longer have access because of minor content change.

@mj8894
Copy link
Author

mj8894 commented Dec 21, 2018

I agree.

However, the idea here was to apply default acl to newly created files using write instead of save option.

@mj8894
Copy link
Author

mj8894 commented Dec 21, 2018

Made Changes to apply default acl only if a new blob is being uploaded to bucket, not affecting ACLs of the already available objects.

@sww314 sww314 added the google label Apr 3, 2019
@cupojoe
Copy link

cupojoe commented Aug 6, 2019

@sww314 Why hasn't this being merged? Anything we can do to get it in? In order for the library to respect the default ACL I had to do a pretty ugly workaround to use save instead of the recommended write.

@jschneier
Copy link
Owner

Fixed by #756.

@jschneier jschneier closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants