Google: Only verify bucket if auto_create is True #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislavb
reviewed
Jun 25, 2019
| @@ -131,17 +130,15 @@ def _get_or_create_bucket(self, name): | |||
| """ | |||
| Retrieves a bucket if it exists, otherwise creates it. | |||
| """ | |||
| if not self.auto_create_bucket: | |||
| return Bucket(client=self.client, name=name) | |||
There was a problem hiding this comment.
Alternative syntax:
Suggested change
| return Bucket(client=self.client, name=name) | |
| return self.client.bucket(name) |
|
I was going to suggest such a change to get rid of storage.buckets.get permission requirement, but found that here it is! It also supersedes #412 |
jschneier
pushed a commit
that referenced
this pull request
Sep 8, 2019
Motivation for this change is to send fewer requests to Google Storage
API. We do not check existence of bucket unless auto_create_bucket is
configured or exists('') is called.
When creating bucket, instead of making two requests to get and create,
we just create and look for conflict.
Based on the work in #575 and supersedes #412.
|
Merged #718 which takes this further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.