Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added GS_AUTO_CREATE_STORAGE_CLASS, GS_AUTO_CREATE_LOCATION settings #405

Closed
wants to merge 1 commit into from

Conversation

f1aky
Copy link

@f1aky f1aky commented Oct 11, 2017

I could not fix the tests for gcloud, can someone else will do it

@sww314 sww314 added the google label Jul 11, 2018
@sww314
Copy link
Contributor

sww314 commented Aug 14, 2018

The storage class should not be responsible for creating the buckets. It makes the most common case retrieving a file more complicated and adds additional network trips to Google. Instead, create your bucket outside the storage class. You need dynamic bucket creation a more explict approach would work better. It also causes permissions problems as the SerivceAccount needs more permissions than it should (#412).

@sww314 sww314 closed this Aug 14, 2018
@jschneier
Copy link
Owner

jschneier commented Aug 31, 2018

I am going to add this concept as a recipe to the docs. This functionality has negative performance impacts on the far more common use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants