Dropbox 8.x support

[danni]

Fixes support for recent versions of the Dropbox SDK.

The API was radically different to the previous SDK, but the mocks used in the unit tests made it so the unit tests appeared to continue passing. This updates the backend to use the return types in the new SDK.

Fixes #396 and #397.

[codecov-io]

Codecov Report

Merging #402 into master will decrease coverage by 0.35%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage    76.1%   75.74%   -0.36%     
==========================================
  Files          11       11              
  Lines        1578     1567      -11     
==========================================
- Hits         1201     1187      -14     
- Misses        377      380       +3

Impacted Files	Coverage Δ
storages/backends/dropbox.py	92.39% <88.88%> (-5.42%)	⬇️
storages/backends/s3boto.py	87.41% <0%> (-0.05%)	⬇️
storages/backends/s3boto3.py	86.54% <0%> (-0.05%)	⬇️
storages/backends/gcloud.py	95.7% <0%> (+0.9%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5649f...ae53ed4. Read the comment docs.

[patroqueeet]

@jschneier when will this be merged and released?

[zuck]

@jschneier Please, merge this PR. I currently have 6 apps in production blocked by this issue...

[4levels]

Same here, please merge this as Dropbox deprecated the old API for Business accounts

[sww314]

@danni Can you resolve conflicts?

[danni]

I don't have a project running on this backend any more. I won't be able to test the result. Is someone else able to merge it?

[sww314]

@4levels or @zuck can your verify this fix? None of the maintainers are currently using the Dropbox integration. If the conflicts are fixed and someone will integration test, we can get it merged.

[4levels]

Hi @sww314,

I'd love to but I'm in no position to do so since my Python skills are very limited.
I also don't understand the merge conflicts listed here, all changes in this PR seem very straightforward.

So far I've managed to get around this by creating a new class as extension, called DropBoxTeamStorage - I needed this anyway since the current DropBoxStorage class cannot handle the extra headers required for Dropbox Team accounts. I then override the listdir method in the new class, making use of the newer Dropbox API response types so I'm not blocked.

PS. I'm curerntly creating a new PR to implement the DropBoxTeam solution I'm using.

Kind regards,

[matburnham]

I can confirm that this seems to work insofar as I can do a listdir which was failing before (#567). I'm not particularly au-fait with git, but have done as much as I can to figure out the merge conflicts.

I could possibly put together another commit to resolve them but I'm not sure I'll then be able to push it anywhere.

• requirements-tests.txt appears to be new so I don't understand why it is conflicting?
• test/test_dropbox.py has mostly minor changes - only two appear to be significant but I don't know how to properly run this test and/or interpret the results
• tox.ini appears to be irrelevant whitespace changes; the only thing significant is pinning dropbox and some other libraries to a particular version; they weren't there before, they can probably be ignored.

If someone can point me to somewhere I can understand about how the tests are supposed to work I can try and figure that out.

[jschneier]

Ended up merging #724. Thanks.