Set a default size when using SpooledTemporaryFile
#1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving `0` as the default means the file never gets rolled over to disk, resulting in higher memory usage than expected (or needed). S3 and GCS both used `0` for their default value. Now, they use `FILE_UPLOAD_MAX_MEMORY_SIZE` (2.5MB by default). This is significantly better than `0`, but still allows configuration as needed. Azure already set a default of 2MB, which is better, but now brought in line with S3 and GCS
RealOrangeOne
force-pushed
the
default-max-memory
branch
from
887237e
to
d893858
Compare
27 tasks
|
This is a breaking change but I think a very reasonable one to follow upstream, thanks. |
|
Everything should go green if you rebase now |
RealOrangeOne
force-pushed
the
default-max-memory
branch
from
d893858
to
90015f3
Compare
|
@jschneier over to you 😄 |
|
Thanks this is a breaking change for people with read only file systems most likely so will need to put it as such in the notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving
0as the default means the file never gets rolled over to disk, resulting in higher memory usage than expected (or needed).S3 and GCS both used
0for their default value. Now, they useFILE_UPLOAD_MAX_MEMORY_SIZE(2.5MB by default). This is significantly better than0, but still allows configuration as needed.Azure already set a default of 2MB, which is better, but now brought in line with S3 and GCS. Dropbox previously didn't allow configuration, so an additional setting was added.