Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: raise FileNotFoundError when requested blob is missing from storage #1358

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Azure: raise FileNotFoundError when requested blob is missing from storage #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aaaed8b
Raise FileNotFoundError when requested blob is missing from Azure sto…
alxbridge Feb 27, 2024
ccb3ee9
Merge remote-tracking branch 'origin/master' into fix/azure-missing-b…
alxbridge May 1, 2024
43e07c8
AzureStorageTest.test_missing_file_handling: use storage's 'open' met…
alxbridge May 1, 2024
eadfbf8
AzureStorageTest.test_missing_file_handling: use context handler when…
alxbridge May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions storages/backends/azure_storage.py
View file
Open in desktop
Expand Up @@ -255,6 +255,8 @@ def _get_valid_path(self, name):
return _get_valid_path(self._normalize_name(clean_name(name)))

def _open(self, name, mode="rb"):
if not self.exists(name):
raise FileNotFoundError('File does not exist: %s' % name)
return AzureStorageFile(name, mode, self)

def get_available_name(self, name, max_length=_AZURE_NAME_MAX_LEN):
Expand Down
10 changes: 10 additions & 0 deletions tests/test_azure.py
View file
Open in desktop
Expand Up @@ -502,3 +502,13 @@ def test_blobserviceclient_no_custom_domain(self):
"https://foo_name.blob.core.windows.net",
credential={"account_name": "foo_name", "account_key": "foo_key"},
)

def test_missing_file_handling(self):
client_mock = mock.MagicMock()
client_mock.exists.side_effect = [True, False]
self.storage._client.get_blob_client.return_value = client_mock

with self.storage.open('file-that-exists') as file_that_exists:
self.assertIsInstance(file_that_exists, azure_storage.AzureStorageFile)

self.assertRaises(FileNotFoundError, self.storage.open, 'file-that-does-not-exist')