[s3] fix disabling cloudfront signing with cloudfront_signer=None #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencehonles
force-pushed
the
fix-cloudfront-with-disabled-signer
branch
from
741680e
to
1d46c04
Compare
|
Thanks, can you add a note to the docs about this piece of functionality. |
terencehonles
force-pushed
the
fix-cloudfront-with-disabled-signer
branch
from
1d46c04
to
4a9d4f5
Compare
This change fixes disabling cloudfront signing by specifying "None" (or another falsy value). This allows multiple storage configs that are all distributed via cloudfront, but only some of the configs need to be signed.
terencehonles
force-pushed
the
fix-cloudfront-with-disabled-signer
branch
from
4a9d4f5
to
36ca80c
Compare
|
Looks great, thanks. |
terencehonles
added a commit
to terencehonles/django-storages
that referenced
this pull request
Nov 1, 2023
This change fixes setting ``cloudfront_signer=None`` as a class variable to disable cloudfront signing (or passing a custom implementation), and is a follow up to jschneier#1326
jschneier
pushed a commit
that referenced
this pull request
Nov 23, 2023
This change fixes setting ``cloudfront_signer=None`` as a class variable to disable cloudfront signing (or passing a custom implementation), and is a follow up to #1326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes disabling cloudfront signing by specifying "None" (or another falsy value). This allows multiple storage configs that are all distributed via cloudfront, but only some of the configs need to be signed.
x-ref: #1302