Add instructions for using django-storages with Scaleway Object storage #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add instructions for using with Scaleway Object Storage
Reformat the code sample - it's not GH markdown
mrchrisadams
changed the title
lvjp
reviewed
Oct 4, 2023
docs/backends/scaleway.rst
Outdated
|
|
||
| - Set ``AWS_BUCKET_NAME`` to the Bucket you want write to (such as ``my-chosen-bucket``) | ||
| - Set ``AWS_S3_REGION_NAME`` to your Scaleway region (such as ``nl-ams`` or ``fr-par``) | ||
| - Set ``AWS_S3_ENDPOINT_URL`` to the value of ``https://{AWS_BUCKET_NAME}.s3.${AWS_S3_REGION_NAME}.scw.cloud`` |
There was a problem hiding this comment.
The bucket name should not be included into the endpoint.
There was a problem hiding this comment.
Thanks Laurent, much appreciated 👍
Co-authored-by: Laurent Verdoïa <verdoialaurent@gmail.com>
|
I've made that change now @lvjp - this look ok now? |
|
The docs have been restructured a bit so that the S3 compatible backends are in their own section. Now that that's inplace I'd be happy to take this if you want to rebase to fit it into that structure. |
lvjp
reviewed
Apr 21, 2024
Comment on lines
+20
to
+22
| If would be written to the following address: | ||
|
|
||
| https://s3.nl-ams.scw.cloud/my-chosen-bucket/my_chosen_file.txt |
There was a problem hiding this comment.
Suggested change
| If would be written to the following address: | |
| https://s3.nl-ams.scw.cloud/my-chosen-bucket/my_chosen_file.txt | |
| If would be written to the following addresses: | |
| https://s3.nl-ams.scw.cloud/my-chosen-bucket/my_chosen_file.txt | |
| https://my-chosen-bucket.s3.nl-ams.scw.cloud/my_chosen_file.txt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi there!
Thank you for creating Django Storage - I figured out how to use it with Scaleway Object storage this week for a project, which is broadly compatible with AWS S3 storage, and I wanted to share this back.
I'm a little rusty with my restructured text, so I've made this draft PR, and once I figure out how to format the code example in the docs, I'll remove the draft status, ready for review.I think I've updated it now.