Improve SFTPStorage #1194
Merged
Improve SFTPStorage #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a third copy of this code would feel silly.
The open method isn't available in all file-like objects one might want to save using the storage framework, so instead of relying on it calling seek(0) for us do it ourselves (conditionally).
This version introduced the SFTPClient.putfo() method. It was released in early 2013, so this shouldn't be a great hardship.
Instead of using SFTPClient.open() to get a file-like object, reading the entire content into memory and then calling .write() on that. The measured performance difference is stunning, and the uploaded file data no longer needs to fit into memory.
|
Looks great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This produces a fairly major difference in performance, the original version needs over 10x the time it takes for the modified version to transfer a 380M test file. Transferring said file with the current version also requires about 2 gigabytes of memory, which drops to 50 megabytes after the change.