Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clean_name to handle pathlib.Path names. #1189

Closed
wants to merge 1 commit into from
Closed

Update clean_name to handle pathlib.Path names. #1189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions storages/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import os
import posixpath
from pathlib import Path

from django.conf import settings
from django.core.exceptions import ImproperlyConfigured
Expand Down Expand Up @@ -32,6 +33,10 @@ def clean_name(name):
"""
Cleans the name so that Windows style paths work
"""
# Convert pathlib.Path to string.
if isinstance(name, Path):
name = str(Path)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this should be str(name).


# Normalize Windows style paths
clean_name = posixpath.normpath(name).replace('\\', '/')

Expand Down