Skip to content

Commit

Permalink
Remove dependency on django.utils.six for Django 3.0 support (#759)
Browse files Browse the repository at this point in the history
  • Loading branch information
yukihira1992 authored and jschneier committed Sep 10, 2019
1 parent 9a5646c commit 0ab2b1e
Show file tree
Hide file tree
Showing 6 changed files with 34 additions and 7 deletions.
9 changes: 7 additions & 2 deletions storages/backends/apache_libcloud.py
Expand Up @@ -9,8 +9,13 @@
from django.core.files.base import File
from django.core.files.storage import Storage
from django.utils.deconstruct import deconstructible
from django.utils.six import string_types
from django.utils.six.moves.urllib.parse import urljoin

try:
from django.utils.six import string_types
from django.utils.six.moves.urllib.parse import urljoin
except ImportError:
string_types = str
from urllib.parse import urljoin

try:
from libcloud.storage.providers import get_driver
Expand Down
6 changes: 5 additions & 1 deletion storages/backends/ftp.py
Expand Up @@ -24,10 +24,14 @@
from django.core.files.base import File
from django.core.files.storage import Storage
from django.utils.deconstruct import deconstructible
from django.utils.six.moves.urllib import parse as urlparse

from storages.utils import setting

try:
from django.utils.six.moves.urllib import parse as urlparse
except ImportError:
from urllib import parse as urlparse


class FTPStorageException(Exception):
pass
Expand Down
7 changes: 6 additions & 1 deletion storages/backends/s3boto3.py
Expand Up @@ -15,14 +15,19 @@
from django.utils.encoding import (
filepath_to_uri, force_bytes, force_text, smart_text,
)
from django.utils.six.moves.urllib import parse as urlparse
from django.utils.timezone import is_naive, make_naive

from storages.utils import (
check_location, get_available_overwrite_name, lookup_env, safe_join,
setting,
)

try:
from django.utils.six.moves.urllib import parse as urlparse
except ImportError:
from urllib import parse as urlparse


try:
import boto3.session
from boto3 import __version__ as boto3_version
Expand Down
6 changes: 5 additions & 1 deletion storages/backends/sftpstorage.py
Expand Up @@ -16,10 +16,14 @@
from django.core.files.base import File
from django.core.files.storage import Storage
from django.utils.deconstruct import deconstructible
from django.utils.six.moves.urllib import parse as urlparse

from storages.utils import setting

try:
from django.utils.six.moves.urllib import parse as urlparse
except ImportError:
from urllib import parse as urlparse


@deconstructible
class SFTPStorage(Storage):
Expand Down
6 changes: 5 additions & 1 deletion tests/test_s3boto.py
Expand Up @@ -12,10 +12,14 @@
from django.core.files.base import ContentFile
from django.test import TestCase
from django.utils import timezone as tz
from django.utils.six.moves.urllib import parse as urlparse

from storages.backends import s3boto

try:
from django.utils.six.moves.urllib import parse as urlparse
except ImportError:
from urllib import parse as urlparse


class S3BotoTestCase(TestCase):
@mock.patch('storages.backends.s3boto.S3Connection')
Expand Down
7 changes: 6 additions & 1 deletion tests/test_s3boto3.py
Expand Up @@ -13,11 +13,16 @@
from django.core.exceptions import ImproperlyConfigured
from django.core.files.base import ContentFile
from django.test import TestCase, override_settings
from django.utils.six.moves.urllib import parse as urlparse
from django.utils.timezone import is_aware, utc

from storages.backends import s3boto3

try:
from django.utils.six.moves.urllib import parse as urlparse
except ImportError:
from urllib import parse as urlparse


try:
from unittest import mock
except ImportError: # Python 3.2 and below
Expand Down

0 comments on commit 0ab2b1e

Please sign in to comment.