Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marked.js.org #1847

Merged
merged 1 commit into from Mar 21, 2018
Merged

marked.js.org #1847

merged 1 commit into from Mar 21, 2018

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Mar 13, 2018 •
edited

Fixes #1846
Waiting for markedjs/marked#1138 to be reviewed (should take a couple days).

  • There is reasonable content on the page (see: No Content)
  • I have read and accepted the ToS

@styfle styfle mentioned this pull request Mar 13, 2018
Closed
@indus indus changed the title Add marked marked.js.org Mar 13, 2018
@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account invalid labels Mar 13, 2018
@indus
Copy link
Member

indus commented Mar 13, 2018

I've already added your requested subdomain to JS.ORGs zonefile. But you have to add a file named CNAME to the docs folder with the single line marked.js.org to make it work.
I'll merge after we have "contact".
You said that this will have to be confirmed by other contributers so it would be good if you can give me an update when the CNAME is added.

@styfle
Copy link
Contributor Author

styfle commented Mar 21, 2018

@indus It looks like it's working! Thanks! 👍

https://marked.js.org/

@indus
Copy link
Member

indus commented Mar 21, 2018

Perfect

@indus indus merged commit de35e1c into js-org:master Mar 21, 2018
@styfle styfle deleted the patch-1 branch January 8, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain invalid organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@styfle @indus