Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shared FFI code #5948

Merged
merged 29 commits into from Feb 18, 2020
Merged

Update shared FFI code #5948

merged 29 commits into from Feb 18, 2020

Commits on Oct 28, 2019

  1. Update configs from FFI and remove generator code.

    @headius
    headius committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    740be10 View commit details
    Browse the repository at this point in the history

  2. Update shared sources from FFI gem.

    @headius
    headius committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    ea20d2d View commit details
    Browse the repository at this point in the history

  3. Update FFI specs from FFI gem.

    @headius
    headius committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    84b5c39 View commit details
    Browse the repository at this point in the history

  4. Add JRuby-specific setup. 

    The load path tweaking was breaking other requires, and this
change aligns how we load JRuby's version of the extension.
    @headius
    headius committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    7ab6328 View commit details
    Browse the repository at this point in the history

  5. Eliminate double-def of FFI::Platform consts and methods.

    @headius
    headius committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    03d2063 View commit details
    Browse the repository at this point in the history

  6. Align VariadicInvoker with FFI gem.

    @headius
    headius committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    aab7c6b View commit details
    Browse the repository at this point in the history

  7. Only add i386 and x86_64 arch if that's the platform. 

    This fixes issues building the test library on Darwin. There's no
reason to build for a platform we won't test.
    @headius
    headius committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    8209ab6 View commit details
    Browse the repository at this point in the history

  8. Just use the Ruby definition of this type.

    @headius
    headius committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    221b11d View commit details
    Browse the repository at this point in the history

  9. javadoc fixes.

    @headius
    headius committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    de3c22a View commit details
    Browse the repository at this point in the history

  10. Partial impl of StructLayout#__union! 

    I'm not sure what the type mapping from the C version corresponds
to in the Java version.
    @headius
    headius committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    051e506 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Merge branch 'master' into update_ffi

    @headius
    headius committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    fa1e977 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. Enums, Enum, and DataConverter are in Ruby now

    @headius
    headius committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    6cc8235 View commit details
    Browse the repository at this point in the history

  2. Align error handling with C ffi

    @headius
    headius committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    4d84cca View commit details
    Browse the repository at this point in the history

  3. Fix all MemoryPointer specs 

    * Fill in missing read/write/put/get aliases
* Add put and get with type
* Change TypeError to ArgumentError
* Don't redispatch to Ruby while looking up type
    @headius
    headius committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    69a1731 View commit details
    Browse the repository at this point in the history

  4. Fix all pointer specs. 

    * AutoPointer is in Ruby now
* Change TypeError to ArgumentError for pointer type failure

Note that this moves AutoPointer cleanup logic from our JVM
Reference-based reaper to one based on ObjectSpace finalizers.
This will mean additional overhead for AutoPointer compared to
the original logic.
    @headius
    headius committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    fb0740a View commit details
    Browse the repository at this point in the history

  5. Order type checks the same as C FFI

    @headius
    headius committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    c647799 View commit details
    Browse the repository at this point in the history

  6. Do not cache the struct layout in the metaclass 

    This caching breaks code that attempts to layout the same struct
class more than once, as in struct_spec.rb's layout specs that
reopen PairLayout in two successive specs.

I do not think this behavior should be supported, and laying out
the same struct twice should probably be an error. Doing it this
way requires at least a guard on the layout value and at most
repeated lookups of that layout via instance variables.
    @headius
    headius committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    21a8a8c View commit details
    Browse the repository at this point in the history

  7. Remove whitespace.

    @headius
    headius committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    a5eb643 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Update specs and libs from ffi gem.

    @headius
    headius committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    3d0cb54 View commit details
    Browse the repository at this point in the history

  2. Revert "Do not cache the struct layout in the metaclass" 

    This reverts commit 21a8a8c.

Per ffi/ffi#734, the behavior that broke this caching is now
deprecated and will be removed in ffi 2.0.
    @headius
    headius committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    95c73a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Merge branch 'master' into update_ffi

    @headius
    headius committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    24f7fc4 View commit details
    Browse the repository at this point in the history

  2. IS_DRAGONFLYBSD is define in Ruby elsewhere now

    @headius
    headius committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    5996596 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2020

  1. remove struct by reference

    @ahorek @headius
    ahorek authored and headius committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    2ab63ec View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2020

  1. throw ArgumentError instead of SecurityError

    @ahorek @headius
    ahorek authored and headius committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    bcec463 View commit details
    Browse the repository at this point in the history

  2. Add FFI::LastError.winapi_error

    @ahorek @headius
    ahorek authored and headius committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    16ea5d2 View commit details
    Browse the repository at this point in the history

  3. [RbConfig] RUBY_SO_NAME and RUBY_BASE_NAME

    @ahorek @headius
    ahorek authored and headius committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    eeb3f6f View commit details
    Browse the repository at this point in the history

  4. x32 build shouldnt contain a prefix

    @ahorek @headius
    ahorek authored and headius committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    843067e View commit details
    Browse the repository at this point in the history

  5. Update specs from ffi gem

    @headius
    headius committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    be3c5c1 View commit details
    Browse the repository at this point in the history

  6. Add missing Field#get and Field#put

    @headius
    headius committed Feb 16, 2020
    Configuration menu
    Copy the full SHA
    f40efb1 View commit details
    Browse the repository at this point in the history