Skip to content

Commit

Permalink
GH Actions: fix build
Browse files Browse the repository at this point in the history
Both Composer, as well as PHPUnit have released new versions to try and fix the issue with tests being run with process isolation, which were resulting in the following error:
```
PHPUnit\Framework\Exception: PHP Fatal error:  strict_types declaration must be the very first statement in the script in /home/runner/work/BrainMonkey/BrainMonkey/vendor/phpunit/phpunit/phpunit on line 2
```

While that fixes the builds for runs against the `highest` versions of dependencies, it still does not solve the problem when running the tests with the `lowest` dependencies.

Build against the `lowest` dependencies now hang indefinitely.

This commit attempts to fix this by using Composer 2.1 for builds against `lowest` dependencies.

It also sets a 15 minute time-out for the test runs against the `lowest` dependencies to prevent builds being very slow in reporting.

Refs:
* composer/composer#10387
* sebastianbergmann/phpunit#4846
* https://github.com/composer/composer/releases/tag/2.2.2
* https://github.com/sebastianbergmann/phpunit/blob/9.5/ChangeLog-9.5.md#9511---2021-12-25
  • Loading branch information
jrfnl committed Dec 29, 2021
1 parent dc58436 commit 0782f2d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/php-qa.yml
Expand Up @@ -35,7 +35,9 @@ jobs:
php-version: ${{ matrix.php-versions }}
ini-values: zend.assertions=1, error_reporting=-1, display_errors=On
coverage: ${{ ( matrix.php-versions == '7.4' && 'xdebug' ) || 'none' }}
tools: parallel-lint
# For running against 'lowest' PHPUnit, Composer < 2.2 is needed due to bug
# https://github.com/composer/composer/issues/10387
tools: ${{ ( matrix.dependency-versions == 'lowest' && 'parallel-lint, composer:v2.1' ) || 'parallel-lint' }}

- name: Check syntax error in sources
if: ${{ matrix.dependency-versions == 'highest' }}
Expand Down Expand Up @@ -64,6 +66,7 @@ jobs:

- name: Run unit tests (without code coverage)
if: ${{ matrix.php-versions != '7.4' || matrix.dependency-versions != 'highest' }}
timeout-minutes: 15
run: ./vendor/bin/phpunit

- name: Run unit tests with code coverage
Expand Down

0 comments on commit 0782f2d

Please sign in to comment.