New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(changelog): handle BREAKING CHANGE from footer #1087
Conversation
8c69156
to
61a440a
Compare
The documentation may need some updates, but i am not sure what ! |
It’s OK, I can take care of the docs. Thank you for the PR! 😁 |
I haven't included yet any change about #806, i wanted to tackle things one at a time. If that PR gets merged, i will have a look at that afterwards. |
sdks/jreleaser-git-java-sdk/src/main/java/org/jreleaser/sdk/git/ChangelogGenerator.java
Outdated
Show resolved
Hide resolved
sdks/jreleaser-git-java-sdk/src/main/java/org/jreleaser/sdk/git/ChangelogGenerator.java
Outdated
Show resolved
Hide resolved
PR failed because of missing license headers. Please invoke |
Would that make sense to add the need to run |
61a440a
to
4a063f4
Compare
On top of the above requested changes, i have also:
|
I'm putting this back to draft, for some reason i can't get the mustache context to contain the additional properties anymore. It used to work, and doesn't since my latest changes, but i have no idea why. |
Introduces a new ConventionalCommit subtype of Commit, which parses the commit body according to conventional commit specification. The conventional-commit preset uses a custom changelog.format instead of replacers to achieve formatting. The changelog presets can now have a custom format. Closes: jreleaser#809
4a063f4
to
948c9af
Compare
I found the problem, should be ready for review! |
Looking pretty good! I wonder if the concept of trailers should be added to the base |
Thanks! 😄 |
Yes, good idea, since conventional commits follows the standard git trailers convention. Could be used for the contributors i think! |
Fixes #809
Context
Introduces a new ConventionalCommit subtype of Commit, which parses the commit body according to conventional commit specification. The conventional-commit preset uses a custom changelog.format instead of replacers to achieve formatting. The changelog presets can now have a custom format.
Checklist
Apache License 2.0, e.g. the code was written by
you or the original code is licensed under a license compatible to Apache License 2.0.