Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom_render.html #2242

Merged
merged 14 commits into from Apr 25, 2024
Merged

Update custom_render.html #2242

merged 14 commits into from Apr 25, 2024

Conversation

markvantilburg
Copy link
Contributor

Fixes mixed content error logging from the demo website over at jqueryui.com

Mixed Content: The page at '<URL>' was loaded over HTTPS, but requested an insecure element '<URL>'. This request was automatically upgraded to HTTPS, For more information see <URL>
VM25 jquery-3.6.0.js:6591 Mixed Content: The page at 'https://jqueryui.com/resources/demos/selectmenu/custom_render.html' was loaded over HTTPS, but requested an insecure element 'http://www.gravatar.com/avatar/b3e04a4…?d=monsterid&r=g&s=16'. This request was automatically upgraded to HTTPS, For more information see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html

Fixes mixed content error logging from the demo website over at jqueryui.com

Mixed Content: The page at '<URL>' was loaded over HTTPS, but requested an insecure element '<URL>'. This request was automatically upgraded to HTTPS, For more information see <URL>
VM25 jquery-3.6.0.js:6591 Mixed Content: The page at 'https://jqueryui.com/resources/demos/selectmenu/custom_render.html' was loaded over HTTPS, but requested an insecure element 'http://www.gravatar.com/avatar/b3e04a4…?d=monsterid&r=g&s=16'. This request was automatically upgraded to HTTPS, For more information see https://blog.chromium.org/2019/10/no-more-mixed-messages-about-https.html
Copy link

linux-foundation-easycla bot commented Apr 22, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@mgol
Copy link
Member

mgol commented Apr 24, 2024

Thanks for the PR. I think I'd like to update all HTTP URLs to HTTPS in one go, at least the ones used in demos. Would you like to try that?

@markvantilburg
Copy link
Contributor Author

see also: #2183

change url to https
update link to https
update link to https
update link to https
update links to https
update links to https
update links to https
update link to https
update link to https
update link to https
update link to https
update links to https
@markvantilburg
Copy link
Contributor Author

updated all http:// links in the demos also checked if these pages are available over https

Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Especially for testing URL availability on HTTPS. 🙂

@mgol mgol added this to the 1.13.3 milestone Apr 25, 2024
@mgol mgol merged commit 2889591 into jquery:main Apr 25, 2024
22 checks passed
@mgol
Copy link
Member

mgol commented Apr 25, 2024

I also fixed #2183 and then I updated remaining HTTP URLs to HTTPS in #2244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants