Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demos: Replace search.php with $.ajaxTransport() mock #2187

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Sep 28, 2023

@Krinkle Krinkle requested a review from mgol September 28, 2023 21:26
@Krinkle Krinkle force-pushed the demos-ajax branch 2 times, most recently from 2ee10b7 to d80d7ae Compare September 28, 2023 22:10
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! A few comments to address, otherwise looks good.

demos/tabs/ajax.html Show resolved Hide resolved
demos/search.js Outdated Show resolved Hide resolved
demos/search.js Show resolved Hide resolved
demos/tabs/ajax.html Show resolved Hide resolved
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mgol mgol added this to the 1.13.3 milestone Jan 3, 2024
@mgol mgol merged commit 604aae1 into jquery:main Jan 3, 2024
5 checks passed
@Krinkle Krinkle deleted the demos-ajax branch January 3, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants