Build:Tests: Fix various issues with running tests on Apple Silicon Macs #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
apple-silicon-updates
branch
3 times, most recently
from
13b52b9
to
6be875c
Compare
mgol
force-pushed
the
apple-silicon-updates
branch
from
6be875c
to
47036d1
Compare
Self-closing tags are reported by newer versions of the htmllint Grunt plugin. They also don't make sense in our HTML files since they are not XHTML-compliant and they run in HTML mode anyway. Ref jquerygh-2157
Some tests were not properly destroying tooltips which made tests start to fail with the new QUnit. Ref jquerygh-2157
`QUnit.jsDump` was renamed to `QUnit.dump` in QUnit 2.0. Ref jquerygh-2157
Also, workaround issues with QUnit Chrome bridge: the Chrome bridge from `grunt-contrib-qunit` is now getting injected into every single iframe, including an empty one that has no intention of running QUnit tests. Since that bridge requires QUnit, it fails with an error in such cases. Workaround the issue by wrapping the bridge in another function that bails early if QUnit is not defined. Ref jquerygh-2157
The `set-output` workflow is deprecated in favor of using environment variables, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Also, fix htmllint lang exclusion patterns. Ref jquerygh-2157
Changes: * add `tests/lib/vendor/**/*` to `.eslintignore` * move `qunit-composite` to `tests/lib` so that we can modify it * move `qunit-assert-classes` to `tests/lib` so that we can modify it * move `qunit-assert-close` to `tests/lib` so that we can modify it * replace `assert.push` with `assert.pushResult` * remove usage of `QUnit.extend` Closes jquerygh-2157
mgol
force-pushed
the
apple-silicon-updates
branch
from
47036d1
to
6a32207
Compare
mgol
added a commit
that referenced
this pull request
May 10, 2023
Self-closing tags are reported by newer versions of the htmllint Grunt plugin. They also don't make sense in our HTML files since they are not XHTML-compliant and they run in HTML mode anyway. Ref gh-2157
mgol
added a commit
that referenced
this pull request
May 10, 2023
Some tests were not properly destroying tooltips which made tests start to fail with the new QUnit. Ref gh-2157
mgol
added a commit
that referenced
this pull request
May 10, 2023
`QUnit.jsDump` was renamed to `QUnit.dump` in QUnit 2.0. Ref gh-2157
mgol
added a commit
that referenced
this pull request
May 10, 2023
mgol
added a commit
that referenced
this pull request
May 10, 2023
Also, workaround issues with QUnit Chrome bridge: the Chrome bridge from `grunt-contrib-qunit` is now getting injected into every single iframe, including an empty one that has no intention of running QUnit tests. Since that bridge requires QUnit, it fails with an error in such cases. Workaround the issue by wrapping the bridge in another function that bails early if QUnit is not defined. Ref gh-2157
mgol
added a commit
that referenced
this pull request
May 10, 2023
Also, fix htmllint lang exclusion patterns. Ref gh-2157
fnagel
reviewed
Sep 4, 2023
There was a problem hiding this comment.
Uhhh, that is a big one! Nice work here!! Sooner or later we'll gotten in trouble with all those old dependencies.
For a proper review, this one is a little too big. I took a brief look at everything and I think its fine. Merged anyway :-D
And again: sorry for the delay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to run UI tests on my new Apple Silicon Mac so I updated all dependencies and fixed all the issues I found. Tests now work fine for me and we have the latest QUnit which is also nice.