Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sortable: Use addClass in _setHandleClassName to improve performance #2063

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

sortable: Use addClass in _setHandleClassName to improve performance #2063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions ui/widgets/sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,19 +118,19 @@ return $.widget( "ui.sortable", $.ui.mouse, {
},

_setHandleClassName: function() {
var that = this;
this._removeClass( this.element.find( ".ui-sortable-handle" ), "ui-sortable-handle" );
$.each( this.items, function() {
that._addClass(
this.instance.options.handle ?
this.item.find( this.instance.options.handle ) :
this.item,
"ui-sortable-handle"
);

// We use addClass() here, instead of _addClass(), because it is much faster.
( this.instance.options.handle ?
this.item.find( this.instance.options.handle ) :
this.item
).addClass( "ui-sortable-handle" );
} );
},

_destroy: function() {
this.element.find( ".ui-sortable-handle" ).removeClass( "ui-sortable-handle" );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at it, I'm not sure about this, it seems to be diverging from how classes are generally managed in jQuery UI.

@fnagel what do you think?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented in the ticket that we use this same current workaround because users reported the same thing 4 years ago. The performance difference with 1000 items is 2 seconds instead of 2+ minutes in the browser

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melloware Thanks, that's an important data point. I'd still want to hear from @fnagel who was involved with UI when the team was larger, I may be lacking some context from those times.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. Still in the process of moving my office and flat.

The thing is that _addClass does keep track of the elements and does some stuff when the element is removed (afair). It's part of the this.options.classes functionality and I think its related to #2037

One objection against this change is that we might reintroduce old issues we once fixed by adding the classes option. Seems we paid for bug fixes with performance penalty.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply. If you aren't comfortable with the patch, you can close it.

I have monkey patched that method in my project, so that I can still use v13 ;-)

this._mouseDestroy();

for ( var i = this.items.length - 1; i >= 0; i-- ) {
Expand Down