Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IE8 support that crashes in some cases (in my case using Drupa… #1897

Closed
wants to merge 1 commit into from

Conversation

joejoseph00
Copy link

Remove useless IE8 support (causes problems in some use cases, particularly when using jQuery ui with the Drupal contrib module named "views_load_more" module.
History is here: #1893
…l and the views_load_more module in combination with jQuery UI 12.1

…l and the views_load_more module in combination with jQuery UI 12.1
@joejoseph00
Copy link
Author

Yay, passing!

Base automatically changed from master to main February 19, 2021 19:58
@mgol mgol added this to the 1.14.0 milestone Dec 2, 2021
@mgol
Copy link
Member

mgol commented Jan 3, 2022

I set the milestone to 1.14.0 it as we agreed not to remove IE 8 workarounds from 1.13 yet. If you'd like to land it sooner, we'd need a way to have the patch apply only when needed. However, the existing check already tries to achieve exactly that... So it'd be good to get more details about the crash: what exactly causes the crash, in which browsers, etc.

@joejoseph00
Copy link
Author

@mgol might as well wait for 1.14.0 .

with that said, IE8 is basically kaput for all intents and purposes. The only people running it would be those not connected to the internet and they'd probably not be changing versions of jQuery.

@mgol mgol closed this Jan 3, 2022
@mgol mgol reopened this Jan 3, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 3, 2022

CLA Signed

The committers are authorized under a signed CLA.

@joejoseph00
Copy link
Author

I signed all the approvals now

@mgol
Copy link
Member

mgol commented Jan 3, 2022

Sure, no problem. Take note, though, that we've released 1.13.0 not so long ago so I wouldn't expect 1.14.0 to arrive any time soon. We want to let it stay on 1.13.0 for a while, let folks update, discover & fix regressions from 1.12.1, etc.

@mgol
Copy link
Member

mgol commented May 10, 2024

We'll be dropping all IE versions in 1.14.0 in a much larger PR. A part of it will be removing the $.fn._form API completely so this PR will not be needed anymore.

Thanks for your contribution anyway!

@mgol mgol closed this May 10, 2024
@mgol mgol removed this from the 1.14.0 milestone May 10, 2024
@mgol
Copy link
Member

mgol commented May 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants