Skip to content

Commit

Permalink
Theme: Fix blank icons having a background
Browse files Browse the repository at this point in the history
A fix from 4325446 introduced a rule setting
`background-image` of a blank icon to none. However, the selector used for that
rule had lower specificity than another one: `.ui-button .ui-icon` which caused
dashes being shown over the icons.

We needed to increase the specificity of the `.ui-icon-blank` rule past the
above selector and past `.ui-button:hover .ui-icon`. We're doing it by repeating
the class name three times.

Closes gh-1987
  • Loading branch information
mgol committed Sep 25, 2021
1 parent b0ed787 commit 87656cd
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion themes/base/theme.css
Expand Up @@ -220,7 +220,10 @@ a.ui-button:active,
}

/* positioning */
html .ui-icon-blank { background-image: none; }
/* Three classes needed to override `.ui-button:hover .ui-icon` */
.ui-icon-blank.ui-icon-blank.ui-icon-blank {
background-image: none;
}
.ui-icon-caret-1-n { background-position: 0 0; }
.ui-icon-caret-1-ne { background-position: -16px 0; }
.ui-icon-caret-1-e { background-position: -32px 0; }
Expand Down

0 comments on commit 87656cd

Please sign in to comment.