Attributes: Don't warn against removeAttr if property false
#484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmethvin
approved these changes
Feb 23, 2023
| // something else than `false`. Otherwise, this Migrate patch | ||
| // doesn't influence the behavior and there's no need to set or warn. | ||
| self.each( function() { | ||
| if ( jQuery( this ).prop( attr ) !== false ) { |
There was a problem hiding this comment.
Could we just use this.attr !== false here?
There was a problem hiding this comment.
I was playing safe to not omit any possible prop hooks. We almost don't have any for boolean props... except for selected in IE:
https://github.com/jquery/jquery/blob/3.6.3/src/attributes/prop.js#L91-L125
It seems we should use the jQuery API then, shouldn't we?
There was a problem hiding this comment.
Yeah I suppose we might add a prop hook so this is the safest way. 👍
Some frameworks, like AngularJS, invoke `removeAttr` on boolean attributes but only after setting the respective property to `false`. Such usage is not dangerous and would continue to work even after Migrate is removed. Therefore, only warn for `removeAttr(booleanAttribute)` if the property wasn't `false` already. Fixes jquerygh-471 Closes jquerygh-484
mgol
force-pushed
the
removeAttr-limit-warnings
branch
from
3a39a9c
to
79e384b
Compare
dmethvin
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some frameworks, like AngularJS, invoke
removeAttron boolean attributes but only after setting the respective property tofalse. Such usage is not dangerous and would continue to work even after Migrate is removed. Therefore, only warn forremoveAttr(booleanAttribute)if the property wasn'tfalsealready.Fixes gh-471