Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed addClassRules to allow "messages" #2446

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -2,7 +2,7 @@
"name": "jquery-validation",
"title": "jQuery Validation Plugin",
"description": "Client-side form validation made easy",
"version": "1.19.6-pre",
"version": "1.19.6-pre2",
"homepage": "https://jqueryvalidation.org/",
"license": "MIT",
"author": {
Expand Down
15 changes: 12 additions & 3 deletions src/core.js
Expand Up @@ -1205,10 +1205,19 @@ $.extend( $.validator, {

addClassRules: function( className, rules ) {
if ( className.constructor === String ) {
this.classRuleSettings[ className ] = rules;
} else {
$.extend( this.classRuleSettings, className );
var obj = {};
obj[ className ] = rules;
className = obj;
}

$.each( className, function( n, r ) {
$( "." + n ).each( function( i, e ) {
var self = $( e );
self.rules( "add", r );
}
);
}
);
},

classRules: function( element ) {
Expand Down
4 changes: 4 additions & 0 deletions test/index.html
Expand Up @@ -462,6 +462,10 @@ <h3></h3>
<form id="testForm28">
<input type="text" name="f28input" required>
</form>
<form id="testForm29" class="testttt">
<input type="text" name="form29field1" id="form29field1" class="class-required-field">
<input type="text" name="form29field2" id="form29field2" class="class-required-field">
</form>
</div>
</body>
</html>
38 changes: 38 additions & 0 deletions test/test.js
Expand Up @@ -2745,3 +2745,41 @@ QUnit.test( "stopRequest() should submit the form once pendingRequests === 0", f
// Submit the form
$( button ).click();
} );

QUnit.test( "addClassRules() with custom messages", function( assert ) {
assert.expect( 2 );
var form = $( "#testForm29" ),
message = "Custom message";

var v = form.validate( {
debug: true
} );

$.validator.addClassRules( "class-required-field", {
required: true,
messages: {
required: message
}
} );

// $( "#form29field1" ).rules("add", {
// required: true,
// messages: {
// required: message
// }
// });
// $( "#form29field2" ).rules("add", {
// required: true,
// messages: {
// required: message
// }
// });

v.form();

var label1 = $( "#form29field1" ).next( ".error:not(input)" ).text();
assert.deepEqual( label1, message );

var label2 = $( "#form29field2" ).next( ".error:not(input)" ).text();
assert.deepEqual( label2, message );
} );