New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced deprecated jQuery functions #2335
Replaced deprecated jQuery functions #2335
Conversation
ba82525
to
38882c7
Compare
38882c7
to
272bb4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good to me. I left a comment about the isArray method that I would like to discuss
Replaced $.isArray and $.isFunction
272bb4f
to
360de29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a lot for your contribution :)
Description
Replaces functions deprecated in jQuery 3 as per https://api.jquery.com/category/deprecated/